Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade git2go to v33 and libgit2 to 1.3 #901

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

tylerphelan
Copy link
Contributor

  • run goimports

@matthewmcnew
Copy link
Collaborator

This will require an update the to kpack/git2go-buildpack

@tylerphelan tylerphelan linked an issue Dec 3, 2021 that may be closed by this pull request
@tylerphelan tylerphelan marked this pull request as draft December 3, 2021 15:27
@tylerphelan
Copy link
Contributor Author

current issues:

@matthewmcnew
Copy link
Collaborator

Should we bump this as well for the github action? https://github.com/pivotal/kpack/blob/main/.github/actions/run-tests/Dockerfile#L1

@tylerphelan tylerphelan marked this pull request as ready for review December 9, 2021 14:47
@tylerphelan
Copy link
Contributor Author

Should we bump this as well for the github action? https://github.com/pivotal/kpack/blob/main/.github/actions/run-tests/Dockerfile#L1

good call

@codecov-commenter
Copy link

Codecov Report

Merging #901 (e53e0ba) into main (36096fc) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   67.63%   67.59%   -0.04%     
==========================================
  Files         117      117              
  Lines        5290     5293       +3     
==========================================
  Hits         3578     3578              
- Misses       1346     1349       +3     
  Partials      366      366              
Impacted Files Coverage Δ
pkg/apis/build/v1alpha2/builder_conversion.go 0.00% <ø> (ø)
.../apis/build/v1alpha2/source_resolver_conversion.go 0.00% <ø> (ø)
pkg/git/fetch.go 76.81% <ø> (ø)
pkg/git/git_keychain.go 81.94% <ø> (ø)
pkg/git/proxy.go 69.23% <ø> (ø)
pkg/git/remote_git_resolver.go 80.64% <ø> (ø)
pkg/git/certificate_check_callback.go 20.68% <25.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36096fc...e53e0ba. Read the comment docs.

- These errors get bubbled up
@tylerphelan tylerphelan merged commit ba72424 into main Dec 9, 2021
@tylerphelan tylerphelan deleted the upgrade-libgit2 branch December 9, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade libgit2 to 1.3
4 participants