toctoc: cross-build toctoc-slick-postgresql for Scala 3#794
Draft
MalpenZibo wants to merge 1 commit into
Draft
Conversation
Bump Slick 3.4.1 -> 3.5.2 (first Slick release with Scala 3 support) and add Scala 3 to crossScalaVersions of toctoc-slick-postgresql. Enables downstream consumers (GDSM) to migrate to Scala 3. Verified: toctocSlickPostgreSql compiles on 3.3.1; both slick modules still compile on 2.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa
Abilita il cross-build Scala 3 di
toctoc-slick-postgresql:crossScalaVersions += scala3sul modulo (come già fatto pertoctoc-coreetoctoc-ldap)3.4.1→3.5.2— 3.5.0 è la prima release di Slick con supporto Scala 3Perché
toctoc-coreè già cross-buildato per Scala 3, ma il binding Slick-Postgres no. Questo blocca i consumer che vogliono migrare a Scala 3 — in particolare GDSM, che usatoctoc-slick-postgresqlper l'autenticazione ed è all'inizio di una migrazione a Scala 3 / rimozione Wiro+Akka.Verifiche
++3.3.1 toctocSlickPostgreSql/compile— compila (nessun cambio al sorgente necessario)++2.13.6 toctocSlickPostgreSql/compilee++2.13.6 toctocSlickMySql/compile— il bump di Slick non rompe il build 2.13 esistente (il modulo MySQL condivide la stessa versione)Nota
Con Slick 3.5.2 su 2.13 compare un warning SIP-51 (scala-library 2.13.6 vs 2.13.14 tirata transitivamente da Slick): benigno, la compilazione riesce. Silenziarlo richiederebbe bumpare la
scalaVersion2.13 dell'intero repo (2.13.6 è datata) — fuori dallo scope di questa PR, valutabile a parte.Scope
Volutamente minimale: solo
build.sbt+project/Dependencies.scala, nessuna modifica alla logica di auth.