Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Commit

Permalink
Don't force line number backgrounds to be white (transparent is better)
Browse files Browse the repository at this point in the history
  • Loading branch information
@keithpitt
keithpitt committed Jan 17, 2019
1 parent e757529 commit bb8aaed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/css/codemirror.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
/* Gutters and line numbers now match our grays */

.CodeMirror-gutters {
background: white;
background: transparent !important;
border: 0;
color: var(--dark-gray);
padding-right: 5px;
}

.CodeMirror-linenumber {
background: white;
background: transparent !important;
}

/* Makes the autocomplete hint dialog match our panels a bit better */
Expand Down

2 comments on commit bb8aaed

@ticky
Copy link
Contributor

@ticky ticky commented on bb8aaed Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithpitt I’m not sure how this is better? It just seems to break things because now we draw text-over-text?

image

@keithpitt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ticky agreed - I was rendering some read-only GraphQL on a gray background and I wanted line numbers to also have a gray background. But I'm doing it differently now.

Revert away!

Please sign in to comment.