Be clear about confirm failure without terminal #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Confirm function now fails by default in non-TTY environments - Shows helpful error message suggesting to use -y/--yes flag - Maintains existing behavior for TTY environments - Adds comprehensive test coverage for new behavior Amp-Thread: https://ampcode.com/threads/T-96c672dc-7e75-4174-b20e-b6bff5e074d5 Co-authored-by: Amp <[email protected]>
- Add TTY wrapper functions in internal/io package - Replace direct isatty usage with IsTerminal() - Centralize TTY detection logic for easier testing and future changes - Update all tests to use the new wrapper functions - isatty package now only imported in one place Amp-Thread: https://ampcode.com/threads/T-96c672dc-7e75-4174-b20e-b6bff5e074d5 Co-authored-by: Amp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #499, this just slightly enhances the built-in confirm process to fail with a clear message in non-terminal environments.
Amp-Thread: https://ampcode.com/threads/T-96c672dc-7e75-4174-b20e-b6bff5e074d5