Replace all spinner.New() calls with TTY-aware SpinWhile #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcncl
previously approved these changes
Jul 7, 2025
sj26
force-pushed
the
implement-spinwhile-everywhere
branch
from
4687578 to
31a86b9
Compare
Member
Author
- Replace spinner.New() calls in 13 files across the codebase - All spinners now use SpinWhile for TTY-aware behavior - Add comprehensive test coverage for TTY/non-TTY scenarios - Ensures CLI works reliably in both interactive and automated environments - Follows patterns from PR #499 for consistent spinner behavior Files updated: - pkg/cmd/job/retry.go - pkg/cmd/build/rebuild.go - pkg/cmd/build/cancel.go - pkg/cmd/build/view.go - pkg/cmd/build/new.go - pkg/cmd/agent/view.go - pkg/cmd/artifacts/download.go - pkg/cmd/build/download.go - pkg/cmd/artifacts/list.go - pkg/cmd/job/unblock.go - pkg/cmd/pipeline/create.go - pkg/cmd/cluster/view.go - internal/pipeline/resolver/repository.go - internal/io/spinner_test.go (enhanced test coverage) Amp-Thread: https://ampcode.com/threads/T-69a131f0-814d-4d1d-b0fc-f7f61f34b1a6 Co-authored-by: Amp <[email protected]>
- Fix gofmt formatting issues in internal/io/spinner_test.go and pkg/cmd/pipeline/create.go - Update AGENT.md with correct golangci-lint command Amp-Thread: https://ampcode.com/threads/T-69a131f0-814d-4d1d-b0fc-f7f61f34b1a6 Co-authored-by: Amp <[email protected]>
sj26
force-pushed
the
implement-spinwhile-everywhere
branch
from
31a86b9 to
4421edf
Compare
Member
Author
|
Rebased 🙏 |
Member
Author
|
Diff looks about right to me 👍 Best viewed ignoring whitespace: |
scadu
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #500, use SpinWhile everywhere that has a spinner so that the CLI works in more non-TTY environments across the board.
Amp's description follows:
Files updated:
Amp-Thread: https://ampcode.com/threads/T-69a131f0-814d-4d1d-b0fc-f7f61f34b1a6
I'll do a little self review, but from a glance it looks good!