Skip to content

Fix SpinWhile #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Fix SpinWhile #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1a8726
Fix SpinWhile to handle non-TTY environments
sj26 Jul 6, 2025
c174da4
Merge branch 'main' into fix-spin-while
mcncl Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/io/spinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ import (
)

func SpinWhile(name string, action func()) error {
if isatty.IsTerminal(os.Stdout.Fd()) {
if !isatty.IsTerminal(os.Stdout.Fd()) {
// No TTY available, just run the action without spinner
action()

return nil
}

// TTY is available, use the spinner
return spinner.New().
Title(name).
Action(action).
Expand Down
21 changes: 21 additions & 0 deletions internal/io/spinner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package io

import (
"testing"
)

func TestSpinWhileWithoutTTY(t *testing.T) {
// Test that SpinWhile works without TTY
actionCalled := false
err := SpinWhile("Test action", func() {
actionCalled = true
})

if err != nil {
t.Errorf("SpinWhile should not return error: %v", err)
}

if !actionCalled {
t.Error("Action should have been called")
}
}