Fix for using rigger with atom #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denar90 thanks for the PR. I might even take a look at removing underscore templates all together as I'm really just doing a fairly simple string replacement, that could probably be handled by something much simpler. Are you able to build your atom package using your modified version? You should be able to reference your github package as a dev dependency until we get a resolution. |
|
Yes, I'll do it this. Should I close this PR? |
|
I'd say leave it open until I get the alternative implementation done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm using
riggerin my Atom package. I'm getting error likeRefused to evaluate a string as JavaScript because 'unsafe-eval'....when rigger uses_.template()method to build template.Here solution which I found and implemented in this pr.