Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused explicit command line overwriting #7734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up unused explicit command line overwriting #7734

wants to merge 1 commit into from

Conversation

maggie-lou
Copy link
Contributor

Related issues: N/A

@maggie-lou maggie-lou mentioned this pull request Oct 11, 2024
Draft
bduffany
bduffany requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm I don't think this is unused - if I run bb test //... --bes_backend=grpc://localhost:1985 --bes_results_url=http://localhost:8080/invocation/

before this PR I see

image

after this PR I see

image

(notice the sidecar stuff showing up in the explicit command line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bduffany bduffany bduffany requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maggie-lou @bduffany