-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explain: Add support for the new exec log format #7730
base: master
Are you sure you want to change the base?
Conversation
Apologies for the large diff, but implementing support for this feature without fixing the mentioned bugs was just too confusing for me. |
Bzlmod tests fail with
even on retries. Maybe something is off with the clock on that executor? |
@fmeum we've seen that error pop up from time to time but haven't yet figured out why it happens. It usually goes away with a re-run. One thing that's suspicious is that |
72d5c13
to
531433d
Compare
In Bazel 7.4.0 and Bazel 8, the compact execlog format has changed and now represents runfiles directories via a dedicated
RunfilesTree
method, which is both more space efficient and also allows attribution of changes to runfiles.This change adds support for the new format and, to get the new tests to pass, also fixes a number of bugs:
TransitivelyInvalidated
no longer counts diamond reverse deps and spawns with multiple outputs twice.