Allow an Admin API key for a 'parent' group to create new groups. #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new groups will inherit the SAML IDP Metadata URL of the original group.
vadimberezniker
force-pushed
the
scim_create_groups
branch
from
b13d4fe
to
b361eb6
Compare
bduffany
approved these changes
Oct 11, 2024
| // For groups created using an API Key allow the SAML IDP Metadata URL | ||
| // to be inherited if the API Key group is marked as a 'parent' group. | ||
| // This allows the new group to be managed using a parent group API key. | ||
| if u.HasCapability(akpb.ApiKey_ORG_ADMIN_CAPABILITY) && u.GetUserID() == "" { |
There was a problem hiding this comment.
nit: the UserID == "" check doesn't seem necessary here? (it might make sense to eventually support ORG_ADMIN for personal API keys)
There was a problem hiding this comment.
This API is also by the web frontend where u.GetUserID() != "" and I don't want this behavior to occur if someone creates a group via the UI. Once the customer is done testing, the plan is to promote the relevant APIs to the public API where we wouldn't need to do this check anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new groups will inherit the SAML IDP Metadata URL of the original group.
Related issues: N/A