Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bazelisk in all GitHub workflows #6638

Merged
merged 3 commits into from
May 23, 2024
Merged

Use bazelisk in all GitHub workflows #6638

merged 3 commits into from
May 23, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented May 23, 2024

Related issues: N/A

@fmeum fmeum requested a review from sluongng May 23, 2024 09:33
sluongng
sluongng approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but since some of these workflows don't run on PR, I would recommend playing around with the on: pull_request:, as well as commenting out any actual release uploads, to verify that the commands are still working as intended before merging.

@fmeum fmeum enabled auto-merge (squash) May 23, 2024 12:23
@fmeum fmeum merged commit c4b6097 into master May 23, 2024
16 of 18 checks passed
@fmeum fmeum deleted the fmeum/consistent-bazel branch May 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sluongng sluongng sluongng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @sluongng