Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend export #424

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Backend export #424

merged 1 commit into from
Dec 29, 2023

Conversation

rroohhh
Copy link
Member

@rroohhh rroohhh commented Dec 28, 2023

No description provided.

@rroohhh rroohhh force-pushed the backend_export branch 2 times, most recently from d829258 to b590683 Compare December 28, 2023 17:42
@rroohhh rroohhh mentioned this pull request Dec 28, 2023
Open
@rroohhh rroohhh force-pushed the backend_export branch 2 times, most recently from 7dda5d5 to 7303c6f Compare December 28, 2023 18:36
phlmn
phlmn approved these changes Dec 28, 2023
View reviewed changes
backend/transcribee_backend/routers/document.py Outdated
@document_router.get("/{document_id}/export/")
async def export(
export_parameters: ExportTaskParameters = Depends(),
auth: AuthInfo = Depends(get_doc_full_auth),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_doc_min_readonly_auth

worker/transcribee_worker/webvtt/export_webvtt.py Outdated
for para in paras:
for atom in para.children:
if not isinstance(atom.end, float) or not isinstance(atom.start, float):
return (False, "Missing timings for atleast one atom")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "atleast" -> "at least"

@phlmn phlmn enabled auto-merge December 28, 2023 18:37
@phlmn phlmn added this pull request to the merge queue Dec 29, 2023
Merged via the queue into main with commit 33b5cbc Dec 29, 2023
2 checks passed
@phlmn phlmn deleted the backend_export branch December 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlmn phlmn phlmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rroohhh @phlmn