Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable asar #448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Enable asar #448

wants to merge 1 commit into from

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Jul 7, 2023

I only did preliminary testing (importing&transcribing, export), but it seems to work on my machine

This should hopefully massively reduce our build times

@pajowu pajowu requested a review from anuejn July 7, 2023 14:37
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me :)
Do you think we should to more testing before shipping this?

@pajowu
Copy link
Member Author

pajowu commented Jul 7, 2023

I'd prefer not to ship this with the 0.3.0, but once that is release, I'd be fine with merging it and then testing it on different plattforms

@pajowu
Copy link
Member Author

pajowu commented Jul 7, 2023

Actually, there is one thing I noticed we have to fix before we can merge this: If I build an app locally and start it, it shows an error message about app-update.yml not existing. But I'm not entirely sure this is related to this PR. But we should investigate that before we merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants