fix: eliminate Redis TOCTOU race on step cache ops - #81
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
Re-resolve the Redis client at each cache call and wrap hgetall/hset/expire in non-throwing helpers so disconnect or resetRedis() between a null-check and use cannot crash step execution. Fixes bug0inc#71 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a classic TOCTOU race between Redis null-checks and later
hgetall/hset/expirecalls (#71).Holding a
getRedis()reference acrossawaitboundaries is unsafe:resetRedis()(e.g. test teardown) or a mid-run disconnect can leave a dangling client that throws and crashes step execution.Changes
src/redis.ts:redisHGetAll,redisHSet,redisExpirerunStepsstep-cache paths and fromdata-cacheglobal/project Redis opsresetRedis()now nulls the module reference beforedisconnect()CHANGELOG.mdentry under[Unreleased]/ FixedTest plan
pnpm run build(tsc clean)vitest:redis.test.ts,data-cache.test.ts,integration/run-steps.test.ts(36 passed)Fixes #71
Signed-off-by: Vedant Madane 6527493+VedantMadane@users.noreply.github.com