curl: only set HTTP1 when HTTP/2 Prior Knowledge and HTTP/3 flags are false #4036
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
changed the title
|
|
|
@emcfarlane tagging you on this since you'll probably have the most context. Thanks! |
|
LGTM @edaniels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v1.57.2, calling
~/go/bin/buf curl -vvvvvv --debug --http2-prior-knowledge --protocol grpc http://127.0.0.1:55555 --list-methodswould result in the TLS handshake hanging. After bisecting down to v1.57.1 being the first bad tag, I found the regression here 2d0ab7a#diff-05c240e5d4191f595d5b747c112c314cf14ee4d77505cee99aac9500eed39527L1135-R1144. I think there are lacking test cases for the buf curl command (unless you have some other acceptance test suite internally), so this was an easy miss. With this, we should be back to insecurely calling gRPC server methods 8).