Use new protocompile/experimental for LSP and implement textDocument/References
#4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
changed the title
protocompile/experimental for LSPprotocompile/experimental for LSP and implement textDocument/References
doriable
force-pushed
the
BSR-5177-lsp-incremental
branch
from
05b811b to
3a8d58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the existing LSP logic to use our new
protocompile/experimentalcompiler.This uses the new compiler's query model to get the IR, which
is used for symbol indexing.
In addition to porting over to the new compiler, this also implements
textDocument/References, which finds all references for a definition,when applicable.