Skip to content

Commit

Permalink
The size parameter for the post thumbnail html filter may be an array…
Browse files Browse the repository at this point in the history 
… or a string

#38
  • Loading branch information
@widoz
widoz committed Sep 26, 2018
1 parent 51d7dce commit 7a7ce11
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion multisite-global-media.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ function adminPostThumbnailHtml(string $content, int $postId, $thumbnailId): str
*
* phpcs:disable Inpsyde.CodeQuality.ArgumentTypeDeclaration.NoArgumentType
*/
function postThumbnailHtml(string $html, int $postId, string $postThumbnailId, string $size, $attr): string
function postThumbnailHtml(string $html, int $postId, string $postThumbnailId, $size, $attr): string
{
// phpcs:enable

Expand Down

2 comments on commit 7a7ce11

@widoz
Copy link
Collaborator Author

@widoz widoz commented on 7a7ce11 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bueltge I missed to create the branch for this fix and committed directly into the master.
Hope isn't a problem it's just removing a type hint.

The parameter passed and allowed by Wp are string and array and there are no other way to fix the #38

@bueltge
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats not any problem. If I will merge in to other branch, I would create them. Thanks for your help!

Please sign in to comment.