BP-3190-Add-getActiveSubscriptions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harli91
previously requested changes
Nov 27, 2023
| }) | ||
| .request(); | ||
| const getActiveSubscriptions = subscription.getActiveSubscriptions() |
There was a problem hiding this comment.
this endpoint is not related to the order subscription service
vildanbina
requested changes
Nov 27, 2023
src/Services/PaymentMethod.ts
Outdated
| @@ -22,7 +22,7 @@ export default abstract class PaymentMethod { | |||
| this._serviceVersion = value; | |||
| } | |||
|
|
|||
| get serviceCode(): ServiceCode { | |||
| get serviceCode(): ServiceCode | string { | |||
There was a problem hiding this comment.
why you've added string as optional cast?
| return subscription | ||
| .create({ | ||
| additionalParameters: { | ||
| signature: 'XXXXXXXX', | ||
| signature: 'XXXXXXXX' |
There was a problem hiding this comment.
start using Prettier in your machine, and keep the structure
| expect(data.hasError()).toBeTruthy(); | ||
| }); | ||
| }); | ||
| test('Update', async () => { | ||
| subscription | ||
| return subscription |
There was a problem hiding this comment.
the return here doesn't matter
vildanbina
reviewed
Nov 29, 2023
vildanbina
requested changes
Nov 29, 2023
execution of Prettier & adjustments on ActiveSubscription class
vildanbina
approved these changes
Nov 30, 2023
Rinor12010
deleted the
BP-3190-Add-GetActiveSubscription-to-retrieve-all-Buckaroo-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.