Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add wal utilization check #178

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Matze-S
Copy link

@Matze-S Matze-S commented Apr 15, 2021

Added a check to monitor wal file utilization in a given past period of time.

The check is based on the modification time of the WAL files and is therefore imprecise within the scope of the WAL segment size, but should be sufficient to monitor storage consumption.

@jonjensen jonjensen changed the title Feature/add wal utilitzation check Feature/add wal utilization check May 14, 2021
Copy link
Member

@jonjensen jonjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

This looks good to me. I just did a code read.

@hasegeli In addition to reading it over, would you try it out too and see what you think?

@hasegeli
Copy link
Member

I ran the tests, and got a failure:

t/02_wal_amount.t .......... 6/12 DBD::Pg::st execute failed: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request. at t/02_wal_amount.t line 76.
# Looks like your test exited with 255 just after 8.
t/02_wal_amount.t .......... Dubious, test returned 255 (wstat 65280, 0xff00)

@Matze-S
Copy link
Author

Matze-S commented May 29, 2021

Hi, I have also run all the tests in a fork of the travis-CI and all tests that are working without the change are fine.
The tests with the newer perl version and the newest postgres database also failed before.
I will try to reproduce the failure and fix it - sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants