Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foundation to 3.2.6 #316

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

acketon
Copy link
Member

@acketon acketon commented Feb 7, 2025

Fixes #315

Changes proposed in this pull request

  • Update grunt-browserify to 6.0 to fix missing dependency: [email protected]

  • Update responsive-foundation to 3.2.5 3.2.6 to get icon and toggle mega menu bug fixes.

Required pull requests to merge (usually a pull request on Foundation or a plugin)

Test sites

Clone these sites to your sandbox, and review them briefly. Does everything work as expected?

Review checklist

  • I have tested my changes in my sandbox on Responsive Framework and at least one child theme.
  • I have tested any new filters or action hooks I have introduced in a child theme to ensure they work correctly.
  • I've reviewed the contribution guidelines.
  • I've updated CHANGELOG.MD with a brief explanation of the changes in this pull request in the unreleased section.
  • My code follows BU Coding Standards.

Copy link
Contributor

@timkingbu timkingbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated inc/template-tags.php and rebuilt js/script.js - the rest looks good

@acketon acketon marked this pull request as ready for review February 14, 2025 19:52
@acketon acketon changed the title Update foundation to 3.2.5 Update foundation to 3.2.6 Feb 14, 2025
Copy link

@saucyrooster saucyrooster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -2133,6 +2133,18 @@ template {
content: "🔧";
}

.lt-ie9:hover .icon-bluesky, .lt-ie9:hover .menu-item [href*="bsky.app"], .menu-item .lt-ie9:hover [href*="bsky.app"] {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is IE9 even required any longer?

@@ -6216,6 +6246,12 @@ a:hover .bu-hub-iconstyles::before {
}
}

@media (min-width: 992px) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is possible but these nth-child declarations are very specific and would remove if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MegaMenu aria-label
3 participants