-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update foundation to 3.2.6 #316
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated inc/template-tags.php
and rebuilt js/script.js
- the rest looks good
77f2a80
to
e057abc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -2133,6 +2133,18 @@ template { | |||
content: "🔧"; | |||
} | |||
|
|||
.lt-ie9:hover .icon-bluesky, .lt-ie9:hover .menu-item [href*="bsky.app"], .menu-item .lt-ie9:hover [href*="bsky.app"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is IE9 even required any longer?
@@ -6216,6 +6246,12 @@ a:hover .bu-hub-iconstyles::before { | |||
} | |||
} | |||
|
|||
@media (min-width: 992px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is possible but these nth-child
declarations are very specific and would remove if we can.
Fixes #315
Changes proposed in this pull request
Update grunt-browserify to 6.0 to fix missing dependency: [email protected]
Update responsive-foundation to
3.2.53.2.6 to get icon and toggle mega menu bug fixes.Required pull requests to merge (usually a pull request on Foundation or a plugin)
Test sites
Clone these sites to your sandbox, and review them briefly. Does everything work as expected?
Review checklist
CHANGELOG.MD
with a brief explanation of the changes in this pull request in the unreleased section.