Resolve "Drop Python 3.8 support" #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 7 7
Lines 314 314
=======================================
Hits 302 302
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue notes, dropping the support for Python 3.8 is the way to go, since the restructuring the CI for just installing the HDF5 headers as well as netcdf from scratch on Windows/Python3.8-runners is just to complex. Since reworking the CI is not worth it, the Python 3.8 support will be dropped, as unit tests and further actions can't run through and thus a stable package is not ensured. Removing Python 3.8 solves this problem.