Allow for custom checkbox and expand icon components by passing through their required actions in the block yield. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d actions through the block yield hash.
Example:
{{#x-tree model=tree checkable=true recursiveCheck=true as |node|}}
<span class="node-checkbox {{if node.model.isChecked 'checked'}}" onclick={{action node.toggleCheck}}></span>
<span class="branch-toggle {{if node.model.isExpanded 'open'}}" {{action node.toggleExpand}}></span>
{{node.model.name}}
{{/x-tree}}
Fixed linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
In order to support custom checkbox and expand icons, an alternative approach to this PR would be to allow implementing apps to toggle checkboxes and branch expansion by adding an onExpanded action, and to run recursive checkbox updates from manual model.isChecked updates instead of only from checkbox click actions.
If this PR is rejected, is that alternative approach preferred?