Extract simnet btcwallet/btcd creation/config into new package #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. I've pushed a fix for the failing build so a rebase might be required. |
| } | ||
|
|
||
| // NewNodeFromArgs starts a new node using the args provided, sets the handlers | ||
| // and loggers. It does not start the node process, Start() should be called for that | ||
| func NewNodeFromArgs(args Args, handlers *rpc.NotificationHandlers, w io.Writer) (*Node, error) { | ||
| func NewNodeFromArgs(args Args, handlers *rpc.NotificationHandlers, w io.Writer, maxRetries int, dataDir string) (*Node, error) { |
There was a problem hiding this comment.
I guess we're assuming dataDir already exists. We can update the docs mentioning this or create the directory if it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts useful functions/types for the purpose launching
btcd/btcwalletprocesses with parameterized configuration options. The motivation for this PR is to publicly expose functionality necessary for creating rpc test-harnesses around btcd/btcwallet.The changes are mostly just moving a set of targeted files into a new package. Constructors around command-line arguments for launching the processes have been modified to include information which were previously a package-level global variables. Additionally,
BtcdArgshas been modified to allow optionally launching a simnet node with theaddrindexactivated.Concerning the name of the package,
simnode, I'm open to any other suggestions. "simnode" seemed to kind of fit.