Upgrade to PrestaShop 8.0 #74

BitcoinMitchell · 2023-01-17T23:10:54Z

Questions	Answers
Description?	This MR upgrades the plugin to PHP 8 (or PHP 8.1) and PrestaShop 8.0. The amount of changes are minimal, but since we are bumping the base PrestaShop requirement (and PrestaShop being PHP 8/8.1 compatible) it would be a waste to not also update our PHP version
Type?	improvement
BC breaks?	yes
Deprecations?	no
Fixed ticket?	Fixes #70

This is currently a draft and testing version will be attached to this MR.

Versions

6.0.0.1: btcpay.zip
6.0.0.2: btcpay.zip
6.0.0.3: btcpay.zip

BitcoinMitchell · 2023-02-01T21:41:12Z

@powerpowera would you be able to test this? I've done some local testing and it looks good, but it would help if someone else could test it as well.

Bumps [symfony/symfony](https://github.com/symfony/symfony) from 4.4.47 to 4.4.50. - [Release notes](https://github.com/symfony/symfony/releases) - [Changelog](https://github.com/symfony/symfony/blob/v4.4.50/CHANGELOG-4.4.md) - [Commits](symfony/symfony@v4.4.47...v4.4.50) --- updated-dependencies: - dependency-name: symfony/symfony dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 4.4.47 to 5.4.20. - [Release notes](https://github.com/symfony/http-kernel/releases) - [Changelog](https://github.com/symfony/http-kernel/blob/6.2/CHANGELOG.md) - [Commits](symfony/http-kernel@v4.4.47...v5.4.20) --- updated-dependencies: - dependency-name: symfony/http-kernel dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

powerpowera · 2023-02-09T00:10:11Z

Page not found
The controller AdminConfigureBTCPay is missing or invalid.

I'm getting this when trying to update.

Everything's fine when I'm using fresh local env.

BitcoinMitchell · 2023-02-09T08:51:51Z

Page not found The controller AdminConfigureBTCPay is missing or invalid.

I'm getting this when trying to update.

Everything's fine when I'm using fresh local env.

Odd, thank you for the feedback! I'll try and figure out why that happens.

BitcoinMitchell · 2023-02-20T23:10:05Z

Resolved an issue with the upgrade script that might relate to the page error. Not 100% sure, but sharing it none-the-less. Will keep looking for other issues.

6.0.0.2: btcpay.zip

Bumps [squizlabs/php_codesniffer](https://github.com/squizlabs/PHP_CodeSniffer) from 3.7.1 to 3.7.2. - [Release notes](https://github.com/squizlabs/PHP_CodeSniffer/releases) - [Commits](squizlabs/PHP_CodeSniffer@3.7.1...3.7.2) --- updated-dependencies: - dependency-name: squizlabs/php_codesniffer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [smarty/smarty](https://github.com/smarty-php/smarty) from 4.2.1 to 4.3.1. - [Release notes](https://github.com/smarty-php/smarty/releases) - [Changelog](https://github.com/smarty-php/smarty/blob/master/CHANGELOG.md) - [Commits](smarty-php/smarty@v4.2.1...v4.3.1) --- updated-dependencies: - dependency-name: smarty/smarty dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

powerpowera · 2023-04-12T15:11:55Z

An exception has been thrown during the rendering of a template ("Unable to generate a URL for the named route "admin_btcpay_configure" as such route does not exist.").

BitcoinMitchell · 2023-04-12T15:14:05Z

An exception has been thrown during the rendering of a template ("Unable to generate a URL for the named route "admin_btcpay_configure" as such route does not exist.").

Could you please provide any additional information? Was this on a fresh install? An upgraded installation? What page did you visit?

ndeet · 2023-05-05T14:13:09Z

Hey, maybe related, when I use your 6.0.0.2 zip above on Presta 8.0.4 and I click on configure after successful install I get:

Page not found.
The controller AdminConfigureBTCPay is missing or invalid.

Looked into config/routes.yaml and maybe the legacy controller mapping does not work anymore? Any idea?

When I go to bank transfer config I see the following in browser url:
https://prestashop.ddev.site/admin-dev/index.php?controller=AdminModules&configure=ps_wirepayment

BTCPay:
https://prestashop.ddev.site/admin-dev/index.php?controller=AdminConfigureBTCPay

In the error logs I see the below error, but seems to be unrelated and only triggered because of some PHP notice breaking some template or something like that.

[05-May-2023 13:54:10] WARNING: [pool www] child 1908 said into stderr: "NOTICE: PHP message: PHP Fatal error:  Uncaught ErrorException: Warning: Undefined property: Symfony\Component\VarDumper\Caster\CutStub::$cache_locking in /var/www/html/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php:737"
[05-May-2023 13:54:10] WARNING: [pool www] child 1908 said into stderr: "Stack trace:"
[05-May-2023 13:54:10] WARNING: [pool www] child 1908 said into stderr: "#0 [internal function]: Smarty_Internal_Template->__destruct()"
[05-May-2023 13:54:10] WARNING: [pool www] child 1908 said into stderr: "#1 {main}"
[05-May-2023 13:54:10] WARNING: [pool www] child 1908 said into stderr: "  thrown in /var/www/html/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 737"

BitcoinMitchell · 2023-05-05T14:16:17Z

Hmmmmm, it would be weird if they break that compatibility, since most plugins I've seen can support Prestashop 1.7 and Prestashop 8. That said, would be worth looking into, thank you for the shout @ndeet.

The warning you see seems to be unrelated yeah.

…low causing exceptions.

The API key is automatically saved once set, so we must manually remove it

BitcoinMitchell · 2023-07-12T15:51:55Z

We've done some more work @powerpowera, would you be willing to try this new version?

6.0.0.3: btcpay.zip

powerpowera · 2023-07-12T19:57:11Z

Sure thing, I'll keep you posted within few days. @BitcoinMitchell

powerpowera · 2023-07-14T11:22:04Z

So far all good! @BitcoinMitchell

BitcoinMitchell · 2023-07-14T11:23:51Z

So far all good! @BitcoinMitchell

Glad to hear it. I'll merge this then and make it the new default version. Thank all for the help

BitcoinMitchell self-assigned this Jan 17, 2023

BitcoinMitchell marked this pull request as draft January 17, 2023 23:11

BitcoinMitchell changed the base branch from 5.x to 6.x January 17, 2023 23:13

BitcoinMitchell force-pushed the 6.x-dev branch from 44e50dc to e001d56 Compare January 17, 2023 23:14

dependabot bot and others added 4 commits February 1, 2023 22:48

Try and resolve local-php-security-checker issues

b1fe4ed

GitHub Workflow changes

cdd91f8

BitcoinMitchell mentioned this pull request Feb 6, 2023

Feature Request: Prestashop 8 support #70

Closed

dependabot bot added 2 commits February 23, 2023 14:13

BitcoinMitchell added 4 commits May 5, 2023 17:19

Upgrade to PrestaShop 8.0

8dea6de

Require BTCPay Server 1.7.0 and up

1ab6788

Ensure the upgrade can be run

b45966a

Updated dependencies

5ba58b4

BitcoinMitchell force-pushed the 6.x-dev branch from f700e2f to 5ba58b4 Compare May 5, 2023 15:57

BitcoinMitchell mentioned this pull request Jul 11, 2023

Ensure PHP 8 and PS 8 compatibility #84

Merged

BitcoinMitchell and others added 5 commits July 12, 2023 17:49

Updated autocomplete.php

68f4303

Updated dependencies

ce634d1

Fix stuff breaking on PS8 on install/uninstall and webhook creation f…

86fc9e5

…low causing exceptions.

Always check for null after building the Client

d405b67

Log more errors and ensure all to have a proper level

7267c7f

BitcoinMitchell added 6 commits July 12, 2023 17:49

Use str_contains over strpos, since we require PHP8

4e090b8

Valid clients can reach the server and the store

1f3c05f

Remove the set API key if the store isn't fully ready yet

c892db7

The API key is automatically saved once set, so we must manually remove it

Use a null check instead an empty check

de278cd

Revert "Use a null check instead an empty check"

5ca5bee

Show more information

8a71b6e

BitcoinMitchell changed the title ~~Draft: Upgrade to PrestaShop 8.0~~ Upgrade to PrestaShop 8.0 Jul 12, 2023

BitcoinMitchell marked this pull request as ready for review July 12, 2023 15:52

BitcoinMitchell merged commit 5a36fd0 into 6.x Jul 14, 2023
4 checks passed

BitcoinMitchell deleted the 6.x-dev branch July 14, 2023 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to PrestaShop 8.0 #74

Upgrade to PrestaShop 8.0 #74

BitcoinMitchell commented Jan 17, 2023 •

edited

Loading

BitcoinMitchell commented Feb 1, 2023

powerpowera commented Feb 9, 2023

BitcoinMitchell commented Feb 9, 2023

BitcoinMitchell commented Feb 20, 2023 •

edited

Loading

powerpowera commented Apr 12, 2023

BitcoinMitchell commented Apr 12, 2023

ndeet commented May 5, 2023

BitcoinMitchell commented May 5, 2023 •

edited

Loading

BitcoinMitchell commented Jul 12, 2023

powerpowera commented Jul 12, 2023

powerpowera commented Jul 14, 2023

BitcoinMitchell commented Jul 14, 2023

Upgrade to PrestaShop 8.0 #74

Upgrade to PrestaShop 8.0 #74

Conversation

BitcoinMitchell commented Jan 17, 2023 • edited Loading

BitcoinMitchell commented Feb 1, 2023

powerpowera commented Feb 9, 2023

BitcoinMitchell commented Feb 9, 2023

BitcoinMitchell commented Feb 20, 2023 • edited Loading

powerpowera commented Apr 12, 2023

BitcoinMitchell commented Apr 12, 2023

ndeet commented May 5, 2023

BitcoinMitchell commented May 5, 2023 • edited Loading

BitcoinMitchell commented Jul 12, 2023

powerpowera commented Jul 12, 2023

powerpowera commented Jul 14, 2023

BitcoinMitchell commented Jul 14, 2023

BitcoinMitchell commented Jan 17, 2023 •

edited

Loading

BitcoinMitchell commented Feb 20, 2023 •

edited

Loading

BitcoinMitchell commented May 5, 2023 •

edited

Loading