Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versioning] Re-use the existing CurlClient for version checking #114

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

BitcoinMitchell
Copy link
Collaborator

@BitcoinMitchell BitcoinMitchell commented Mar 13, 2024

Description

The Prestashop team found an issue with the module whilst testing.

After installation they ran into an issue with a class not being available on a brand new instance. I've tried to replicate this issue, but was unable to and AFAIK, nobody else has had this issue, so it might be related to their test setup (as the backend theme in the video looks very different).

That said, since Guzzle requires a lot of packages to work and there is no real way to talk to the Prestashop Module team, I've decided to just simplify the whole process. To do so I've simply re-used the already existing (and known to be working) BTCPayServer CurlClient.

Type of change

Refactor (non-breaking change which improves the codebase).

How Has This Been Tested?

Uploaded the module locally on a clean Prestashop installation (using the one they showed in the video).

Test Configuration:

  • BTCPay Server version: 1.12.5
  • PrestaShop version: 8.1.0
  • PHP version: 8.1.22

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Less dependencies is always good and lowers the pain in the future 😆

@BitcoinMitchell BitcoinMitchell merged commit b37761e into 6.x Mar 14, 2024
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the simplify-update-check branch March 14, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants