[Versioning] Re-use the existing CurlClient for version checking #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Prestashop team found an issue with the module whilst testing.
After installation they ran into an issue with a class not being available on a brand new instance. I've tried to replicate this issue, but was unable to and AFAIK, nobody else has had this issue, so it might be related to their test setup (as the backend theme in the video looks very different).
That said, since Guzzle requires a lot of packages to work and there is no real way to talk to the Prestashop Module team, I've decided to just simplify the whole process. To do so I've simply re-used the already existing (and known to be working) BTCPayServer
CurlClient
.Type of change
Refactor (non-breaking change which improves the codebase).
How Has This Been Tested?
Uploaded the module locally on a clean Prestashop installation (using the one they showed in the video).
Test Configuration:
Checklist: