docker-compose.yml Fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker volume in docker-compose is being mounted at /data rather than /export. Without changing this, any data stored by minio at runtime is lost since it is not persistently stored in a volume.
The /app directory has already been copied into the docker image. There is no reason to mount it again at runtime via a volume.
The worker-minio containers depend on the minio service starting first.
The added text in the README.md file helps to differentiate the uses of the docker-compose.yml and docker-stack.yml files as well as explains a little on how to manage the example service.
This new file allows the example service to be started on a docker swarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the tutorial originally posted and soon after decided to do some testing on the result. I found that the data stored by minio was not persistent across restarts of the service. I ended up finding a bug in the compose file regarding the minio storage path.
I started to also question how the docker-compose.yml file could be simplified. I found that I could remove the
appdirectory mounts because the necessary files had already been copied into the docker images.I began experimenting with
docker stackwhich takes some slightly different syntax regarding the restart policy as well as not allowing thebuildkey. I decided to create adocker-stack.ymlfile for myself and wanted to give back to the tutorial if it indeed adds benefit.