Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo, Column One & Column Two Color Scheme Adjustments #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PetrosPec
Copy link

Logo Light/Dark Mode Variant
Column Background Style
Column Two in Column One Adjustments

@PetrosPec PetrosPec requested a review from derB4 December 3, 2024 15:53
@PetrosPec PetrosPec self-assigned this Dec 3, 2024
@PetrosPec PetrosPec requested a review from LukasBSI December 3, 2024 15:54
@PetrosPec PetrosPec closed this Dec 3, 2024
@PetrosPec PetrosPec reopened this Dec 3, 2024
CHANGELOG.md Show resolved Hide resolved
@@ -19,9 +19,9 @@
<td style="width: 100%; text-align: {{ headerLogoAlign }};" valign="{{ headerLogoAlign }}">
<![endif]-->
{% if headerLogoHeight > 0 %}
<img data-bsi-element-part="{{ headerLogoPartId }}" src="{{ headerLogoSrc }}" height="{{ headerLogoHeight }}" alt="" style="margin: 0; display: inline-block; width: auto; max-width: 100%; height: {{ headerLogoHeight }}px;" />
<img data-bsi-element-part="{{ headerLogoPartId }}" src="{{ headerLogoSrc }}" class="headerLogo" height="{{ headerLogoHeight }}" alt="" style="margin: 0; display: inline-block; width: auto; max-width: 100%; height: {{ headerLogoHeight }}px;" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brauchen wir die Klasse?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fehlt in diesem Template nicht das dark-mode-bild?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich bin verwirrt - was ist der Unterschied zwischen header-logo und logo?

Comment on lines +30 to +43
<td width="30" style="background-color: {{ npsButtonBackgroundColor }}; text-align: center; vertical-align: middle;" >
<a href = "" class="nps-dm-button" data-bsi-element-part="link0" style="background-color: {{ npsButtonBackgroundColor }}; mso-line-height-rule: exactly; font-size: {{ npsFontSize }}px; line-height: {{ npsFontSize }}px; font-family: {{ npsFontFamily }}; color: {{ npsButtonColor }}; font-weight: {{ npsFontWeight }}; text-decoration: none; mso-border-alt: none; border-radius: {{ npsBorderRadius }}px; display: inline-block; text-align:center; word-break: keep-all; text-underline-color: {{ npsButtonBackgroundColor }};">1</a>
</td>
<td width="5" style="width: 5px;"></td>
<td width="30" style="background-color: {{ npsButtonBackgroundColor }}; text-align: center; vertical-align: middle;">
<a href = "" class="nps-dm-button" data-bsi-element-part="link1" style="background-color: {{ npsButtonBackgroundColor }}; mso-line-height-rule: exactly; font-size: {{ npsFontSize }}px; line-height: {{ npsFontSize }}px; font-family: {{ npsFontFamily }}; color: {{ npsButtonColor }}; font-weight: {{ npsFontWeight }}; text-decoration: none; mso-border-alt: none; border-radius: {{ npsBorderRadius }}px; display: inline-block; text-align:center; word-break: keep-all; text-underline-color: {{ npsButtonBackgroundColor }};">2</a>
</td>
<td width="5" style="width: 5px;"></td>
<td width="30" style="background-color: {{ npsButtonBackgroundColor }}; text-align: center; vertical-align: middle;">
<a href = "" class="nps-dm-button" data-bsi-element-part="link2" style="background-color: {{ npsButtonBackgroundColor }}; mso-line-height-rule: exactly; font-size: {{ npsFontSize }}px; line-height: {{ npsFontSize }}px; font-family: {{ npsFontFamily }}; color: {{ npsButtonColor }}; font-weight: {{ npsFontWeight }}; text-decoration: none; mso-border-alt: none; border-radius: {{ npsBorderRadius }}px; display: inline-block; text-align:center; word-break: keep-all; text-underline-color: {{ npsButtonBackgroundColor }};">3</a>
</td>
<td width="5" style="width: 5px;"></td>
<td width="30" style="background-color: {{ npsButtonBackgroundColor }}; text-align: center; vertical-align: middle;">
<a href = "" class="nps-dm-button" data-bsi-element-part="link3" style="background-color: {{ npsButtonBackgroundColor }}; mso-line-height-rule: exactly; font-size: {{ npsFontSize }}px; line-height: {{ npsFontSize }}px; font-family: {{ npsFontFamily }}; color: {{ npsButtonColor }}; font-weight: {{ npsFontWeight }}; text-decoration: none; mso-border-alt: none; border-radius: {{ npsBorderRadius }}px; display: inline-block; text-align:center; word-break: keep-all; text-underline-color: {{ npsButtonBackgroundColor }};">4</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twig for-each?

package.json Show resolved Hide resolved
Comment on lines +63 to +66
/* Behaviour Col 2/3 in Col 1 */
.bsi-col-one .dropzone-col-two-left {
padding: 10px 10px 10px 0px !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist das mit Outlook / Litmus getestet?

Comment on lines +53 to +57
/* Hide dark-mode logo on default */
.headerLogoDarkMode {
display: none;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versteckst du es nur hier? Glaube nicht, dass das gut geht.
Mein Ansatz: im HTML ein style="display: none" setzen und im scss ein "display: block !important;"

styles/styles.scss Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants