Replace jail command fork with libjail-rs #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfreyer
suggested changes
Jan 2, 2019
| passthru: bool | ||
| ) -> None: | ||
|
|
||
| running_jail = self._launch_jail() |
There was a problem hiding this comment.
It might make more sense to do this the other way around, and call self._launch_persistent_jail() from _launch_jail(), as libjail-rs jails are by default persistent, and you can drop persistence after spawning the command using jail.RunningJail.defer_cleanup.
| ) | ||
| if returncode > 0: | ||
| try: | ||
| return jail.start() |
There was a problem hiding this comment.
this should be stopped_jail.start()
|
Although it was tempting to use a well designed rust library, the idea was hold back in favor of py-freebsd_sysctl and py-jail that are native Python implementations. The close relation to libjail-rs gives us the ability to share unit tests of those projects, so that either the Python and Rust bindings can benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in progress branch of libjail-rs is providing Python bindings for its interfaces:
fubarnetes/libjail-rs#14
With this bindings libiocage gains more control over jail interaction and also boosts performance.