Fix labwc-9999 build failing due to missing libsfdo #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGazotti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labwc added support for window icons in labwc/labwc@a745f91, using libsfdo.
That feature is enabled by default and will result in a configure error if that library isn't found.
Commits add a very crude but working ebuild for gui-libs/libsfdo and the 'icons' USE flag to labwc to enable optionally building that feature.
Alternatively, we could just add the libsfdo tarball to the ebuild as an exception for the network sandbox and allow labwc's meson scripts to build and bundle it.