-
Couldn't load subscription status.
- Fork 6
Upstream docker/venv improvements #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dylan Schultz <[email protected]>
Signed-off-by: Dylan Schultz <[email protected]>
Signed-off-by: Dylan Schultz <[email protected]>
Signed-off-by: Dylan Schultz <[email protected]>
Signed-off-by: Dylan Schultz <[email protected]>
|
Hey @dylanschultzie just checking in on this WIP. Last i heard you said it wasn't ready to be reviewed yet. I'v moved it to draft for the time being, but lemme know when your ready for review, and happy to give it a look |
|
@danbryan ready for review 👍 |
|
Hey @dylanschultzie , I tested out the changes tonight and I think this is a good idea. I’m not very experienced with Gunicorn or uv, so I spent some time reading up and experimenting. One thing I ran into: I wasn’t able to get the same detailed, rolling logs with Gunicorn as I do when running the app directly with python app.py (see screenshot). I tried several Gunicorn options, including: but couldn’t replicate the same log output. Do you know if there’s a way to achieve this with Gunicorn, or is there a recommended approach for getting similar logs in production? Also, I’d suggest updating the setup so that docker-compose reads the Flask port from the .env file, rather than hardcoding it. Along those lines, it might be best to remove the EXPOSE instruction from the Dockerfile and let Compose or other orchestration tools handle port exposure, which would make the setup more flexible. Thanks again for your work on this and any advice you can share about logging! |
|
@danbryan those are all great suggestions, I'll see if I can figure out the logging difference shortly. |

Key changes:
uv