CrateDB: Accept protocol scheme alias cratedb:// for source adapter

[amotl]

About

While the CrateDB source adapter is using crate://, based on CrateDB's SQLAlchemy dialect, the destination adapter is using cratedb://, based on dlt-postgres. In this spirit, CrateDB's source vs. destination adapters are using totally different implementations and protocols.

The idea is to at least harmonize the "naming things" details on database addressing concerns, so it becomes less confusing for users, and less of an anomaly for the [new] product landing page generator.

-- https://getbruin.com/product/ingestion/

References

• [DOCS] Ingest data from anywhere: CrateDB destination uses wrong protocol scheme bruin#1640

Review

Also FYI, @seut, @matriv, @surister, @hammerhead, and @zolbatar.

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

String replacement is unsafe - will replace any occurrence of sslmode={value} in the entire URI, including passwords or hostnames containing this substring.

Use parsed_uri._replace() and urlencode() like other URI transformations in this file (lines 156-158, 172-175):

Suggested change

	uri = uri.replace(f"sslmode={sslmode}", f"ssl={ssl}")
	query_params["ssl"] = [ssl]
	del query_params["sslmode"]
	uri = parsed_uri._replace(query=urlencode(query_params, doseq=True)).geturl()

Prompt To Fix With AI

This is a comment left during a code review.
Path: ingestr/src/sources.py
Line: 240:240

Comment:
String replacement is unsafe - will replace any occurrence of `sslmode={value}` in the entire URI, including passwords or hostnames containing this substring.

Use `parsed_uri._replace()` and `urlencode()` like other URI transformations in this file (lines 156-158, 172-175):

```suggestion
                query_params["ssl"] = [ssl]
                del query_params["sslmode"]
                uri = parsed_uri._replace(query=urlencode(query_params, doseq=True)).geturl()
```

How can I resolve this? If you propose a fix, please make it concise.

[amotl]

Thanks. The patch was improved accordingly.