Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow compiling to wasm32-wasi #165

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

fibonacci1729
Copy link
Contributor

This fixes a type mismatch when compiling wasm-opt targeting wasm32-wasi.

error[E0308]: mismatched types
   --> wasm-opt-0.116.0/src/base.rs:397:8
    |
397 |     Ok(path)
    |     -- ^^^^ expected `&[u8]`, found `&Path`
    |     |
    |     arguments to this enum variant are incorrect
    |
    = note: expected reference `&[u8]`
               found reference `&Path`

cc @alexcrichton

@alexcrichton
Copy link

👋 @brson long time no see!

@brson
Copy link
Owner

brson commented Mar 28, 2024

Thanks @fibonacci1729 @alexcrichton I'll aim to get this into a point release this weekend.

@brson
Copy link
Owner

brson commented Mar 28, 2024

Looks like the CI failure is unrelated.

@brson brson merged commit 20d2c39 into brson:master Mar 31, 2024
7 of 17 checks passed
@brson
Copy link
Owner

brson commented Mar 31, 2024

This is published as 0.116.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants