Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce route Skipper #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

thzois
Copy link

@thzois thzois commented Jun 16, 2022

Hello!

Thank you very much for providing this middleware to the community :) We have been actively using it in our company, but we noticed that for health probes it constantly produces logs that we are not interested in. This PR introduces a Skipper, so that someone can decide to exclude certain routes from getting logged when a request arrives.

I have added the related tests and in order to be backwards compatible with the previous version of the middleware, I have added a default configuration.

@starkers
Copy link

@thzois I'm guessing this is unmaintained at this point

@VDVsx
Copy link

VDVsx commented May 24, 2023

This would be nice to have in, perhaps @brpaz can have a look?

VDVsx added a commit to Unity-Technologies/echozap that referenced this pull request May 26, 2023
Since the forked repo appeared to be unmaintained,
we are pulling this open PR in:
brpaz#4

Signed-off-by: Valério Valério <[email protected]>
@webstradev
Copy link

This would be very usefull

@salleh
Copy link

salleh commented Sep 8, 2023

It is ashamed that this feature are yet to be introduced to the main release. Open source development is understandably can be time consuming without probable material gain and we can hardly blame contributors for not that active in maintaining the releases.

I too actively using this middleware for logging my echo instances.

If it is not too much to ask can I volunteer my spare times to help maintaining this repo @brpaz?

@thzois
Copy link
Author

thzois commented Sep 28, 2023

Apologies for the late response, I thought this repository was unmaintained! @salleh did you merge this PR? Can we close it?

@salleh
Copy link

salleh commented Oct 11, 2023

Apologies for the late response, I thought this repository was unmaintained! @salleh did you merge this PR? Can we close it?

I've merged the changes into my own fork. Not to this source repo. I've also added my own enhancement to the package there and propose that to be merged here as you can see in the other pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants