feat(EWM-561): multiple workchains #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/EWM-560_v2_config # Conflicts: # assets/configs/connections_v2.json # lib/app/service/connection/data/connection_config/connection_config.dart # lib/app/service/connection/data/connection_data/connection_data.dart # lib/app/service/connection/data/connection_data/connection_data.freezed.dart # lib/app/service/connection/data/connection_data/connection_data.g.dart # lib/app/service/connection/data/connection_network/connection_network.dart # lib/app/service/connection/data/wallet_default_account_names.dart # lib/app/service/connection/data/work_chain/connection_work_chain_data.dart # lib/app/service/connection/default_network.dart # lib/app/service/connection/json_converters/multisig_type_converter.dart # lib/app/service/connection/mapping/connection_network_mapper.dart # lib/app/service/connection/mapping/networks_mapper.dart # lib/app/service/connection/transport_strategies/common_transport_strategy.dart # lib/generated/assets.gen.dart
…ure/EWM-560_v2_config # Conflicts: # lib/generated/assets.gen.dart
Odrin
reviewed
Oct 9, 2025
| @@ -1,5 +1,5 @@ | |||
| import 'package:app/app/router/router.dart'; | |||
| import 'package:app/app/service/service.dart'; | |||
| import 'package:app/app/service/connection/data/network_type.dart'; | |||
Collaborator
There was a problem hiding this comment.
Может добавить экспорты в app/service/service.dart? Во многих файлах поменялись только импорты, как тут.
Odrin
reviewed
Oct 9, 2025
| import 'package:app/utils/parse_utils.dart'; | ||
| import 'package:get_storage/get_storage.dart'; | ||
|
|
||
| class StorageMigrationV6 implements StorageMigration { |
Collaborator
There was a problem hiding this comment.
Нужна миграция сетей, созданных пользователем.
# Conflicts: # lib/app/service/connection/data/connection_transport/connection_transport_data.dart # lib/app/service/connection/mapping/transports_mapper.dart # lib/app/service/connection/transport_strategies/common_transport_strategy.dart # lib/di/di.config.dart # lib/feature/browser_v1/approvals_listener/actions/change_network/change_network_wm.dart # lib/generated/assets.gen.dart
…ins' into feature/EWM-561-multiple_workchains # Conflicts: # lib/di/di.config.dart
knightsforce
changed the title
Odrin
reviewed
Oct 20, 2025
| _connectionsIdsSubject.add(_readConnectionsIds()); | ||
| } | ||
|
|
||
| bool checkIsFrom0To1Workchain(String address) { |
Collaborator
There was a problem hiding this comment.
- Странный метод для storage service'а
- Почему
String? У нас естьAddressс геттеромworkchain - Почему хардкод на конкретные workchain id? Логично сделать что-то вроде
isCrosschain
Collaborator
Author
There was a problem hiding this comment.
- Есть места где адрес передается строчно. Например текстовый ввод.
- Нам нужно заблочить именно с 0 на 1. Есть случаи когда можем слать с одного воркчейна на другой.
…h, mobile_scanner, sqlite3, and flutter_native_splash
…e-deps' into feature/EWM-561-merge # Conflicts: # lib/app/service/assets_service.dart # lib/app/service/connection/connection_service.dart # lib/app/service/connection/data/connection_data/connection_data.dart # lib/app/service/connection/data/connection_data/connection_data.freezed.dart # lib/app/service/connection/data/connection_data/connection_data.g.dart # lib/app/service/connection/data/connection_network/connection_network.dart # lib/app/service/connection/data/connection_transport/connection_transport_data.dart # lib/app/service/connection/data/custom_network/custom_network_option.dart # lib/app/service/connection/data/default_active_asset.dart # lib/app/service/connection/data/nft_information/nft_information.freezed.dart # lib/app/service/connection/data/nft_information/nft_information.g.dart # lib/app/service/connection/data/transport_icons.dart # lib/app/service/connection/data/transport_manifest_option/transport_manifest_option.freezed.dart # lib/app/service/connection/data/transport_native_token_option/transport_native_token_option.freezed.dart # lib/app/service/connection/mapping/connection_network_mapper.dart # lib/app/service/connection/mapping/networks_mapper.dart # lib/app/service/connection/mapping/transports_mapper.dart # lib/app/service/connection/transport_strategies/common_transport_strategy.dart # lib/app/service/current_accounts_service.dart # lib/app/service/presets_connection/presets_connection_service.dart # lib/app/service/storage_service/connections_storage_service.dart # lib/app/service/storage_service/migrations/storage_migrations/v5.dart # lib/core/app_build_type.dart # lib/data/models/approval_request.freezed.dart # lib/di/di.config.dart # lib/feature/browser_v1/approvals_listener/actions/change_network_sheet.dart # lib/feature/browser_v1/utils.dart # lib/feature/browser_v2/inpage_provider/inpage_provider.dart # lib/feature/choose_network/choose_network_screen_model.dart # lib/feature/network/bottom_sheets/select_network/select_network_widget.dart # lib/feature/network/configure_networks/configure_networks_wm.dart # lib/feature/network/edit_network/edit_network_wm.dart # lib/feature/network/view/network_item.dart # lib/feature/presets_config/data/connection_network_dto.freezed.dart # lib/feature/presets_config/data/connection_network_dto.g.dart # lib/feature/presets_config/data/preset_config_type.dart # lib/feature/wallet/view/wallet_view.dart # lib/feature/wallet/widgets/select_account/select_account_model.dart # lib/generated/assets.gen.dart # lib/utils/parse_utils.dart # lib/widgets/network_drop_item.dart # pubspec.lock # pubspec.yaml
# Conflicts: # lib/app/service/assets_service.dart # lib/app/service/connection/connection_service.dart # lib/app/service/connection/data/connection_data/connection_data.dart # lib/app/service/connection/data/connection_data/connection_data.freezed.dart # lib/app/service/connection/data/connection_data/connection_data.g.dart # lib/app/service/connection/data/connection_network/connection_network.dart # lib/app/service/connection/data/connection_transport/connection_transport_data.dart # lib/app/service/connection/data/custom_network/custom_network_option.dart # lib/app/service/connection/data/default_active_asset.dart # lib/app/service/connection/data/nft_information/nft_information.freezed.dart # lib/app/service/connection/data/nft_information/nft_information.g.dart # lib/app/service/connection/data/transport_icons.dart # lib/app/service/connection/data/transport_manifest_option/transport_manifest_option.freezed.dart # lib/app/service/connection/data/transport_native_token_option/transport_native_token_option.freezed.dart # lib/app/service/connection/mapping/connection_network_mapper.dart # lib/app/service/connection/mapping/networks_mapper.dart # lib/app/service/connection/mapping/transports_mapper.dart # lib/app/service/connection/transport_strategies/common_transport_strategy.dart # lib/app/service/current_accounts_service.dart # lib/app/service/presets_connection/presets_connection_service.dart # lib/app/service/storage_service/connections_storage_service.dart # lib/app/service/storage_service/migrations/storage_migration_service.dart # lib/app/service/storage_service/migrations/storage_migrations/v5.dart # lib/core/app_build_type.dart # lib/data/models/approval_request.freezed.dart # lib/di/di.config.dart # lib/feature/browser_v1/approvals_listener/actions/change_network_sheet.dart # lib/feature/browser_v1/utils.dart # lib/feature/browser_v2/inpage_provider/inpage_provider.dart # lib/feature/choose_network/choose_network_screen_model.dart # lib/feature/network/bottom_sheets/select_network/select_network_widget.dart # lib/feature/network/configure_networks/configure_networks_wm.dart # lib/feature/network/edit_network/edit_network_wm.dart # lib/feature/network/view/network_item.dart # lib/feature/presets_config/data/connection_network_dto.freezed.dart # lib/feature/presets_config/data/connection_network_dto.g.dart # lib/feature/presets_config/data/preset_config_type.dart # lib/feature/wallet/view/wallet_view.dart # lib/feature/wallet/wallet_prepare_transfer/wallet_prepare_transfer_page_wm.dart # lib/feature/wallet/widgets/select_account/select_account_model.dart # lib/generated/assets.gen.dart # lib/utils/parse_utils.dart # lib/widgets/network_drop_item.dart # pubspec.lock # pubspec.yaml
Odrin
approved these changes
Oct 23, 2025
Odrin
changed the title
# Conflicts: # lib/app/service/connection/data/nft_information/nft_information.dart # lib/app/service/connection/data/nft_information/nft_information.g.dart # lib/app/service/storage_service/migrations/storage_migrations/storage_migrations.dart # lib/di/di.config.dart # lib/feature/browser_v2/screens/main/widgets/pages/page/browser_page_model.dart # lib/feature/network/edit_network/edit_network_page_widget.dart # pubspec.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change