refactor: update SDK setup to use config and improve instructions #94
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the BrowserStack SDK setup process by replacing environment variable usage with a centralized configuration object. The changes improve maintainability and make it easier to manage credentials and settings across the SDK. Below are the most important changes grouped by theme:
Refactoring to use centralized configuration:
src/tools/sdk-utils/commands.tsto importconfigfrom../../config.jsand replacedprocess.env.BROWSERSTACK_USERNAMEandprocess.env.BROWSERSTACK_ACCESS_KEYwithconfig.browserstackUsernameandconfig.browserstackAccessKeyin SDK setup commands. [1] [2] [3]src/tools/sdk-utils/constants.tsto useconfig.browserstackUsernameandconfig.browserstackAccessKeyfor defining credentials in example configurations.Updates to instructions:
src/tools/sdk-utils/instructions.tsto include clearer placeholders for project and build names, replacing hardcoded values with sample values and adding comments for customization.