Skip to content

AAP-18921: RN 0.80 reflection field-name fix (cherry-pick of upstream PR #4812) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sriteja777 wants to merge 2 commits into
base: release-20.38.0-cloud.1
Choose a base branch
from
+32 −5
Open

AAP-18921: RN 0.80 reflection field-name fix (cherry-pick of upstream PR #4812) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ffe3c
fix(android): branch RN reflection field names by version (AAP-18921)
sriteja777 May 4, 2026
56cd43b
Revert manual version bump; let Jenkins publish job set -cloud.x
sriteja777 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .../full/java/com/wix/detox/reactnative/idlingresources/network/NetworkingModuleReflected.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,28 @@ package com.wix.detox.reactnative.idlingresources.network
import android.util.Log
import com.facebook.react.bridge.ReactContext
import com.facebook.react.modules.network.NetworkingModule
import com.wix.detox.reactnative.ReactNativeInfo
import okhttp3.OkHttpClient
import org.joor.Reflect
import org.joor.ReflectException


private const val LOG_TAG = "RNNetworkingModuleRefl"

private const val FIELD_OKHTTP_CLIENT = "mClient"
private const val FIELD_OKHTTP_CLIENT_PRE80 = "mClient"
private const val FIELD_OKHTTP_CLIENT = "client"

internal class NetworkingModuleReflected(private val reactContext: ReactContext) {
fun getHttpClient(): OkHttpClient? {
val networkNativeModule = reactContext.getNativeModule(NetworkingModule::class.java)
try {
return Reflect.on(networkNativeModule).field(FIELD_OKHTTP_CLIENT).get()
val fieldName = if (ReactNativeInfo.rnVersion().minor > 79) {
FIELD_OKHTTP_CLIENT
} else {
FIELD_OKHTTP_CLIENT_PRE80
}

return Reflect.on(networkNativeModule).field(fieldName).get()
} catch (e: ReflectException) {
Log.e(LOG_TAG, "Can't set up Networking Module listener", e)
return null
Expand Down
25 changes: 22 additions & 3 deletions ...tox/src/full/java/com/wix/detox/reactnative/idlingresources/timers/JavaTimersReflected.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.wix.detox.reactnative.idlingresources.timers

import com.facebook.react.bridge.ReactContext
import com.facebook.react.modules.core.JavaTimerManager
import com.wix.detox.reactnative.ReactNativeInfo
import org.joor.Reflect
import kotlin.reflect.full.declaredFunctions
import kotlin.reflect.jvm.isAccessible
Expand All @@ -19,8 +20,26 @@ object JavaTimersReflected {
}

private fun getTimersManager(reactContext: ReactContext): JavaTimerManager {
val reactHost = Reflect.on(reactContext).field("mReactHost").get<Any>()
val reactInstance = Reflect.on(reactHost).field("mReactInstance").get<Any>()
return Reflect.on(reactInstance).field("mJavaTimerManager").get() as JavaTimerManager
val reactHostFieldName = if (ReactNativeInfo.rnVersion().minor > 79) {
"reactHost"
} else {
"mReactHost"
}

val reactInstanceFieldName = if (ReactNativeInfo.rnVersion().minor > 80) {
"reactInstance"
} else {
"mReactInstance"
}

val javaTimerManagerFieldName = if (ReactNativeInfo.rnVersion().minor > 79) {
"javaTimerManager"
} else {
"mJavaTimerManager"
}

val reactHost = Reflect.on(reactContext).field(reactHostFieldName).get<Any>()
val reactInstance = Reflect.on(reactHost).field(reactInstanceFieldName).get<Any>()
return Reflect.on(reactInstance).field(javaTimerManagerFieldName).get() as JavaTimerManager
}
}