Skip to content

fix: Skip checking if the browser is installed on Windows #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ueokande wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: Skip checking if the browser is installed on Windows #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/channel_windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,11 @@ export class WindowsChannelInstaller implements Installer {
throw new Error(`Unexpected version: ${version}`);
}

const root = this.browserRootDir(version);
try {
await fs.promises.stat(root);
} catch (e) {
if (isENOENT(e)) {
return undefined;
}
throw e;
}

return { root, bin: "chrome.exe" };
// Skip checking if the browser is installed by the official installer.
// The official installer installs to the default location and
// some github-hosted runners have outdated versions.
// It enables us to use the latest version of the browser.
return undefined;
}

async downloadBrowser(version: string): Promise<DownloadResult> {
Expand Down
Loading