Move Monolog to dev

[mostafasoufi]

Regarding PR #465, why isn't MonoLog included in the development environment when it's used in the Commands classes for Unit tests?

Best

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (003b4d2) 36.26% compared to head (184d27d) 36.26%.

Additional details and impacted files

@@            Coverage Diff            @@
##              7.5.x     #660   +/-   ##
=========================================
  Coverage     36.26%   36.26%           
  Complexity      286      286           
=========================================
  Files            27       27           
  Lines          1183     1183           
=========================================
  Hits            429      429           
  Misses          754      754           

Flag	Coverage Δ
phpunit	36.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mimmi20]

@mostafasoufi Monolog is used in the File src/Helper/LoggerHelper.php. This Helper is used in all Commands, not just in the Tests. If you want to make Monolog optional, you have to change that file too, and maybe all places where this Helper is used.

[mostafasoufi]

They are only uses in /bin/browscap-php which is not the main functionality of Browscap, isn't it?

[mimmi20]

Browscap can be used in two ways:

1. as Component for other projects, where it is installed via composer
2. as Standalone Project

In the second Way, you can use these Commands. I do not know, if anyone uses Browscap this way.

If Monolog is transfered to the dev-section, these Commands will break. This means that will be a breaking change.

[mimmi20]

Please add also an Comment in the Readme (where these Commands are listed), that the User has to install Monolog.

[mimmi20]

Please add "monolog/monolog" also in the suggest section with an comment, that this is required for the console commands.

[asgrim]

I would suggest this is not mergable at least until the next major, since it would indeed break this functionality. It would help if we knew if people use this functionality or not 🤷

[asgrim]

@mostafasoufi thank you for the PR, but since this is functionality people may use, which would break, this wouldn't be acceptable until a major release really. I'd suggest making an issue to see if others have feedback about it and we can discuss what the migration path might look like. Thank you though, we really appreciate it!

[mostafasoufi]

I inquired because I'm planning to upgrade Browscap for WordPress plugins like WP Statistics and SlimStat Analytics. However, since the pull request (PR) is closed, it looks like I'll need to fork the project and work on my own repository.