Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth-Astro for GitHub authentication #88

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Sep 6, 2024

Uses https://www.npmjs.com/package/auth-astro to handle the github oauth

Copy link

github-actions bot commented Sep 6, 2024

Visit the preview URL for this PR (updated for commit c9fd46f):

https://mmp-site-b1c9b--pr88-auth-astro-github-r5da6oig.web.app

(expires Wed, 25 Sep 2024 17:26:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link

@broarr broarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does it work?

@broarr
Copy link

broarr commented Sep 9, 2024

Looks like the callback urls are not set up correctly?

@galenwinsor
Copy link
Contributor

@hetd54 what's the latest with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants