Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Smart Lock C33 (T85L0) #528

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jhongturney
Copy link

@jhongturney jhongturney commented Aug 7, 2024

The value in types.ts needs to be updated to the actual value as I was not able to get the updated value from the API. Otherwise the pattern I followed was the same as the T8506.

@bropat
Copy link
Owner

bropat commented Aug 18, 2024

@jhongturney

Have you tested all the functionality on the device?

@jhongturney
Copy link
Author

@bropat Not as of yet. Would you be able to help with the PR to update the types value? I don't think I have the setup required to determine that value.

@jhongturney
Copy link
Author

jhongturney commented Sep 16, 2024

@bropat I think I've got it from the dev console calls:

image

Edit: How can I test this against my own device? Are you able to release a beta build?
Edit2: Nevermind, I just made the edits to the js files on my Pi and restarted the child bridge. Everything is showing up as expected:
image

but not necessarily working... Trying to unlock the door from HomeKit:

[EufySecurity]  INFO    Garage Door Lock target state set to: 0

but no change to the actual state. Maybe a result of me editing files in place, or maybe something missed in the changes.

@jhongturney
Copy link
Author

I've checked the properties for the C33/T85L0 that I can see via the dev console when changing locked to unlocked in the Eufy app, and it's using the same values as my T8506, so I'd expect everything to work with the changes in this PR that's just copy/pasting/extending the same functionality with a new ID value. I think whatever issues I'm hitting is just due to me updating in place in a very hacky way.

If you have a proper way to test that you can document I'd be happy to do so!

@bropat
Copy link
Owner

bropat commented Sep 17, 2024

@jhongturney

One aspect is that the attributes are read and displayed correctly, another is how the commands must be sent via the P2P protocol. There are often major differences here, even with apparently very similar devices.
The best would be, if possible, that you share your device with me, then I can test and implement everything necessary.

If you have a proper way to test that you can document I'd be happy to do so!

Unfortunately, I don't currently have any documentation to test or to easily find out what the correct P2P commands are for the device.

@jhongturney jhongturney marked this pull request as draft September 18, 2024 20:09
@jhongturney
Copy link
Author

Unfortunately, I already have some bad news... This device does not use P2P communication at all (is the first one I see 🙁) for controlling the device.
All communication is via MQTTS (security-mqtt-us.anker.com).
So the device is not compatible with the current implementation.

#526 (comment)

@wsaeed
Copy link

wsaeed commented Nov 12, 2024

Any update on the pull request?

@jhongturney
Copy link
Author

@wsaeed No, sorry - I've had zero time to take a look at this again. Maybe I'll get a chance over the holidays.

@wsaeed
Copy link

wsaeed commented Nov 14, 2024

@jhongturney I can contribute too. I just need initial guidance to set up the dev environment.

@gbrogna
Copy link

gbrogna commented Nov 23, 2024

How can I use this updated code (add it as a repository in Home Assistant) so I can take advantage of the E33 at any level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants