-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Smart Lock C33 (T85L0) #528
base: master
Are you sure you want to change the base?
Conversation
Have you tested all the functionality on the device? |
@bropat Not as of yet. Would you be able to help with the PR to update the types value? I don't think I have the setup required to determine that value. |
@bropat I think I've got it from the dev console calls: Edit: How can I test this against my own device? Are you able to release a beta build? but not necessarily working... Trying to unlock the door from HomeKit:
but no change to the actual state. Maybe a result of me editing files in place, or maybe something missed in the changes. |
I've checked the properties for the C33/T85L0 that I can see via the dev console when changing locked to unlocked in the Eufy app, and it's using the same values as my T8506, so I'd expect everything to work with the changes in this PR that's just copy/pasting/extending the same functionality with a new ID value. I think whatever issues I'm hitting is just due to me updating in place in a very hacky way. If you have a proper way to test that you can document I'd be happy to do so! |
One aspect is that the attributes are read and displayed correctly, another is how the commands must be sent via the P2P protocol. There are often major differences here, even with apparently very similar devices.
Unfortunately, I don't currently have any documentation to test or to easily find out what the correct P2P commands are for the device. |
|
Any update on the pull request? |
@wsaeed No, sorry - I've had zero time to take a look at this again. Maybe I'll get a chance over the holidays. |
@jhongturney I can contribute too. I just need initial guidance to set up the dev environment. |
How can I use this updated code (add it as a repository in Home Assistant) so I can take advantage of the E33 at any level? |
The value in
types.ts
needs to be updated to the actual value as I was not able to get the updated value from the API. Otherwise the pattern I followed was the same as the T8506.