Wrappers missing return's

brockhaus · Dec 6, 2018 · 60cc911 · 60cc911
1 parent e0fa9f7
commit 60cc911
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 11 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,6 @@
 vendor
 composer.lock
-bin/
+bin/
+/composer
+/composer.phar
+/.idea
diff --git a/Library/AddressValidationWrapper.php b/Library/AddressValidationWrapper.php
@@ -49,7 +49,7 @@ public function validate(
         $requestOption = AddressValidation::REQUEST_OPTION_ADDRESS_VALIDATION,
         $maxSuggestion = 15
     ) {
-        $this->upsAddressValidation->validate($address, $requestOption, $maxSuggestion);
+        return $this->upsAddressValidation->validate($address, $requestOption, $maxSuggestion);
     }
 
     /**

diff --git a/Library/RateWrapper.php b/Library/RateWrapper.php
@@ -43,7 +43,7 @@ public function __construct(Rate $upsRate)
      */
     public function shopRates($rateRequest)
     {
-        $this->upsRate->shopRates($rateRequest);
+        return $this->upsRate->shopRates($rateRequest);
     }
 
     /**

diff --git a/Library/ShippingWrapper.php b/Library/ShippingWrapper.php
@@ -37,14 +37,15 @@ public function __construct(\Ups\Shipping $upsShipping)
      * @param Shipment                                 $shipment
      * @param ShipmentRequestLabelSpecification|null   $labelSpec
      * @param ShipmentRequestReceiptSpecification|null $receiptSpec
+     * @return \stdClass
      */
     public function confirm(
         $validation,
         Shipment $shipment,
         ShipmentRequestLabelSpecification $labelSpec = null,
         ShipmentRequestReceiptSpecification $receiptSpec = null
     ) {
-        $this->upsShipping->confirm(
+        return $this->upsShipping->confirm(
             $validation,
             $shipment,
             $labelSpec,
@@ -54,33 +55,36 @@ public function confirm(
 
     /**
      * @param $shipmentDigest
+     * @return \stdClass
      */
     public function accept($shipmentDigest)
     {
-        $this->upsShipping->accept($shipmentDigest);
+        return $this->upsShipping->accept($shipmentDigest);
     }
 
     /**
      * @param $shipmentData
+     * @return \stdClass
      */
     public function void($shipmentData)
     {
-        $this->upsShipping->void($shipmentData);
+        return $this->upsShipping->void($shipmentData);
     }
 
     /**
      * @param $trackingData
      * @param null $labelSpecification
      * @param null $labelDelivery
      * @param null $translate
+     * @return \stdClass
      */
     public function recoverLabel(
         $trackingData,
         $labelSpecification = null,
         $labelDelivery = null,
         $translate = null
     ) {
-        $this->upsShipping->recoverLabel(
+        return $this->upsShipping->recoverLabel(
             $trackingData,
             $labelSpecification,
             $labelDelivery,

diff --git a/Library/TrackingWrapper.php b/Library/TrackingWrapper.php
@@ -45,7 +45,7 @@ public function __construct(Tracking $upsTracking)
      */
     public function track($trackingNumber, $requestOption = 'activity')
     {
-        $this->upsTracking->track($trackingNumber, $requestOption);
+        return $this->upsTracking->track($trackingNumber, $requestOption);
     }
 
     /**
@@ -59,7 +59,7 @@ public function track($trackingNumber, $requestOption = 'activity')
      */
     public function trackByReference($referenceNumber, $requestOption = 'activity')
     {
-        $this->upsTracking->trackByReference($referenceNumber, $requestOption);
+        return $this->upsTracking->trackByReference($referenceNumber, $requestOption);
     }
 
     /**

diff --git a/Library/TradeabilityWrapper.php b/Library/TradeabilityWrapper.php
@@ -41,7 +41,7 @@ public function __construct(Tradeability $upsTradeability)
      */
     public function getLandedCosts(LandedCostRequest $request)
     {
-        $this->upsTradeability->getLandedCosts($request);
+        return $this->upsTradeability->getLandedCosts($request);
     }
 
     /**

diff --git a/composer.json b/composer.json
@@ -1,5 +1,5 @@
 {
-  "name": "octante/ups-api-bundle",
+  "name": "brockhaus/ups-api-bundle",
   "type": "symfony-bundle",
   "description": "UPS API Bundle for Symfony2 and Symfony3",
   "keywords": ["ups", "ups bundle", "symfony", "shipping"],