Skip to content

Commit 3282979

Browse files
authored
Merge pull request #995 from broadinstitute/dp-dxwdl
bugfixes and deoptimize
2 parents 83a5fab + 19dab54 commit 3282979

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

metagenomics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ def krona(inReport, db, outHtml, queryColumn=None, taxidColumn=None, scoreColumn
821821
if '<attribute display="Avg. score">score</attribute>' in line:
822822
line = line.replace('Avg. score', 'Est. unique kmers')
823823
print(line, file=new_report)
824-
os.rename(fn, outHtml)
824+
shutil.copyfile(fn, outHtml)
825825
return
826826
elif inputType == 'kaiju':
827827
kaiju = tools.kaiju.Kaiju()

pipes/WDL/workflows/tasks/tasks_demux.wdl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ task illumina_demux {
4949
Boolean? forceGC=true
5050

5151

52-
parameter_meta {
53-
flowcell_tgz : "stream" # for DNAnexus, until WDL implements the File| type
54-
}
52+
# parameter_meta {
53+
# flowcell_tgz : "stream" # for DNAnexus, until WDL implements the File| type
54+
# }
5555
5656
command {
5757
set -ex -o pipefail

pipes/WDL/workflows/tasks/tasks_metagenomics.wdl

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ task krakenuniq {
33
File krakenuniq_db_tar_lz4 # krakenuniq/{database.kdb,taxonomy}
44
File krona_taxonomy_db_tgz # taxonomy/taxonomy.tab
55
6-
parameter_meta {
7-
krakenuniq_db_tar_lz4: "stream" # for DNAnexus, until WDL implements the File| type
8-
krona_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
9-
reads_unmapped_bam: "stream" # for DNAnexus, until WDL implements the File| type
10-
}
6+
# parameter_meta {
7+
# krakenuniq_db_tar_lz4: "stream" # for DNAnexus, until WDL implements the File| type
8+
# krona_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
9+
# reads_unmapped_bam: "stream" # for DNAnexus, until WDL implements the File| type
10+
# }
1111
1212
command {
1313
set -ex -o pipefail
@@ -79,9 +79,9 @@ task krona {
7979

8080
String input_basename = basename(classified_reads_txt_gz, ".txt.gz")
8181

82-
parameter_meta {
83-
krona_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
84-
}
82+
# parameter_meta {
83+
# krona_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
84+
# }
8585
8686
command {
8787
set -ex -o pipefail
@@ -122,9 +122,9 @@ task filter_bam_to_taxa {
122122

123123
String input_basename = basename(classified_bam, ".bam")
124124

125-
parameter_meta {
126-
ncbi_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
127-
}
125+
# parameter_meta {
126+
# ncbi_taxonomy_db_tgz : "stream" # for DNAnexus, until WDL implements the File| type
127+
# }
128128
129129
command {
130130
set -ex -o pipefail
@@ -179,11 +179,11 @@ task kaiju {
179179
180180
String input_basename = basename(reads_unmapped_bam, ".bam")
181181

182-
parameter_meta {
183-
kaiju_db_lz4 : "stream" # for DNAnexus, until WDL implements the File| type
184-
ncbi_taxonomy_db_tgz : "stream"
185-
krona_taxonomy_db_tgz : "stream"
186-
}
182+
# parameter_meta {
183+
# kaiju_db_lz4 : "stream" # for DNAnexus, until WDL implements the File| type
184+
# ncbi_taxonomy_db_tgz : "stream"
185+
# krona_taxonomy_db_tgz : "stream"
186+
# }
187187
188188
command {
189189
set -ex -o pipefail

tools/krona.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from builtins import super
66

77
TOOL_NAME = 'krona'
8-
CONDA_TOOL_VERSION = '2.7'
8+
CONDA_TOOL_VERSION = '2.7.1'
99

1010

1111
class Krona(tools.Tool):

0 commit comments

Comments
 (0)