Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scroll performance #202

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve scroll performance #202

wants to merge 4 commits into from

Commits on Aug 10, 2016

  1. Fix tag mismatch in feed view template

    @MichaelEischer
    MichaelEischer committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    36d27c1 View commit details
    Browse the repository at this point in the history

  2. Avoid layout reflow when selecting a feed entry 

    Even though the modified border width and padding did cancel each other
a full layout recalculation was necessary. This is rather expensive when a
lot of entries are loaded.
This patch avoids the problem by adding a second div with a border that
is invisible by default. If an entry is selected, the border's color is updated.
See https://developer.mozilla.org/en-US/docs/Tools/Performance/Scenarios/Animating_CSS_properties#CSS_property_cost
for some details on the costs of a CSS property.
    @MichaelEischer
    MichaelEischer committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    4fb2894 View commit details
    Browse the repository at this point in the history

  3. Only update the feed view header border attribute before painting

    @MichaelEischer
    MichaelEischer committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    4e55960 View commit details
    Browse the repository at this point in the history

  4. Try to avoid some unnecessary calls to _fillWindow

    @MichaelEischer
    MichaelEischer committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    752dcd8 View commit details
    Browse the repository at this point in the history