Closed
Conversation
Member
|
@DeniseSl22, I'm going to need some more explanation about what the |
Author
|
@egonw , those other files were made by you (at least the commits are), I'm not sure what that's about. I will try to make a fresh branch which is in line with the current main, and perform my PR again (without the other files). |
Member
|
Oh! Sorry, I did not see that. And bad me for writing lazy commit messages :( |
Member
|
@tabbassidaloii, can you please review this patch? |
tabbassidaloii
approved these changes
Jul 8, 2022
Member
@egonw I would only merge README.md. How the package should be installed is already in the README file and the other file doesn't make sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing rJava was not straightforward, so I added some more hints on that @egonw