Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports embedded images #200

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Supports embedded images #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de307aa
chore: Now exports binary files
bric3 Jan 12, 2024
dd95267
feature: Show logs inlays
bric3 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions excalidraw-assets/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const defaultInitialData = {
const initialData = anyWindow.initialData ?? defaultInitialData;

class ExcalidrawApiBridge {
private readonly excalidrawRef: any;
private readonly excalidrawApiRef: React.Ref<ExcalidrawImperativeAPI | null>;
private continuousSavingEnabled = true;
private _setTheme: React.Dispatch<Theme> | null = null;
set setTheme(value: React.Dispatch<Theme>) {
Expand All @@ -49,49 +49,50 @@ class ExcalidrawApiBridge {
}

constructor(excalidrawRef: React.MutableRefObject<ExcalidrawImperativeAPI | null>) {
this.excalidrawRef = excalidrawRef;
this.excalidrawApiRef = excalidrawRef;
window.addEventListener(
"message",
this.pluginMessageHandler.bind(this)
);
}

private excalidraw() {
return this.excalidrawRef.current;
private excalidrawApi() : ExcalidrawImperativeAPI {
// @ts-ignore // Object is initialized in constructor
return this.excalidrawApiRef.current;
}

// @ts-ignore
readonly updateApp = ({elements, appState}) => {
this.excalidraw().updateScene({
this.excalidrawApi().updateScene({
elements: elements,
appState: appState,
});
};

readonly updateAppState = (appState: object) => {
this.excalidraw().updateScene({
elements: this.excalidraw().getSceneElements(),
this.excalidrawApi().updateScene({
elements: this.excalidrawApi().getSceneElements(),
appState: {
...this.excalidraw().getAppState(),
...this.excalidrawApi().getAppState(),
...appState
},
});
};

readonly saveAsJson = () => {
let binaryFiles = {};
return serializeAsJSON(
this.excalidraw().getSceneElements(),
this.excalidraw().getAppState(),
binaryFiles,
this.excalidrawApi().getSceneElements(),
this.excalidrawApi().getAppState(),
this.excalidrawApi().getFiles(),
"local"
)
};

readonly saveAsSvg = (exportParams: object) => {
console.debug("saveAsSvg export config", exportParams);
let sceneElements = this.excalidraw().getSceneElements();
let appState = this.excalidraw().getAppState();
let sceneElements = this.excalidrawApi().getSceneElements();
let appState = this.excalidrawApi().getAppState();
let files = this.excalidrawApi().getFiles();

// Doc: https://docs.excalidraw.com/docs/@excalidraw/excalidraw/api/utils/export#exporttosvg
return exportToSvg({
Expand All @@ -101,16 +102,16 @@ class ExcalidrawApiBridge {
...exportParams,
exportEmbedScene: true,
},
files: {},
files: files,
});
};

readonly saveAsBlob = (exportParams: object, mimeType: string) => {
console.debug("saveAsPng export config", exportParams);
let sceneElements = this.excalidraw().getSceneElements();
let appState = this.excalidraw().getAppState();
let sceneElements = this.excalidrawApi().getSceneElements();
let appState = this.excalidrawApi().getAppState();
let files = this.excalidrawApi().getFiles();

let binaryFiles = {};
// Doc: https://docs.excalidraw.com/docs/@excalidraw/excalidraw/api/utils/export#exporttoblob
return exportToBlob({
elements: sceneElements,
Expand All @@ -119,7 +120,7 @@ class ExcalidrawApiBridge {
...exportParams,
exportEmbedScene: true,
},
files: binaryFiles,
files: files,
mimeType: mimeType,
});
};
Expand Down Expand Up @@ -182,7 +183,7 @@ class ExcalidrawApiBridge {
this.currentSceneVersion = updateSceneVersion;
this.updateApp({
elements: elements || [],
appState: {} // TODO load appState ?
appState: {}, // TODO load appState ?
});
}
break;
Expand Down Expand Up @@ -219,7 +220,7 @@ class ExcalidrawApiBridge {
this.currentSceneVersion = updateSceneVersion;
this.updateApp({
elements: restoredState.elements || [],
appState: {} // TODO load appState ? (restoredState.appState)
appState: {}, // TODO load appState ? (restoredState.appState)
});
}
})
Expand Down
1 change: 1 addition & 0 deletions plugin/src/main/kotlin/com/github/bric3/excalidraw/editor/ExcalidrawWebViewController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ class ExcalidrawWebViewController(
window.postMessage({
type: "update",
elements: json.elements
files: json.files
}, 'https://$pluginDomain')
"""
)
Expand Down
Loading