Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmac: Use non-panicking Digest API throughout. #2193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

briansmith
Copy link
Owner

Make the nature of panics in the HMAC module clearer--ring::hmac APIs only panic when the input is too long.

@briansmith briansmith self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (a8619bc) to head (758ec0e).

Files with missing lines Patch % Lines
src/hmac.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         154      154           
  Lines       20235    20264   +29     
  Branches      461      461           
=======================================
+ Hits        19612    19641   +29     
  Misses        518      518           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Make the nature of panics in the HMAC module clearer--`ring::hmac`
APIs only panic when the input is too long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant