hmac internals: Make it clearer that Context::try_sign doesn't panic.
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
==========================================
- Coverage 96.91% 96.91% -0.01%
==========================================
Files 154 154
Lines 20239 20240 +1
Branches 461 461
==========================================
Hits 19615 19615
Misses 520 520
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
Use `Digest::try_finish()` instead of `Digest::finish()`. Calculate `num_pending` directly from the inner digest, so that the compiler can use `OutputLen` range analysis to prove that the buffer is large enough.
briansmith
force-pushed
the
b/try_sign-panic
branch
from
96ca635 to
c85a1a4
Compare
briansmith
changed the title
Context::try_sign.Context::try_sign doesn't panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Digest::try_finish()instead ofDigest::finish().Calculate
num_pendingdirectly from the inner digest, so that the compiler can useOutputLenrange analysis to prove that the buffer is large enough.