Use only non-panicking digest API internally. #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/panic-less-1
branch
from
b435005 to
a2734b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
- Coverage 96.92% 96.88% -0.04%
==========================================
Files 154 154
Lines 20235 20311 +76
Branches 461 461
==========================================
+ Hits 19612 19678 +66
- Misses 518 528 +10
Partials 105 105 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/panic-less-1
branch
from
a2734b8 to
d742e3a
Compare
Make the nature of panics in the HMAC module clearer--`ring::hmac` APIs only panic when the input is too long.
Expose `digest::try_finish` to the rest of the crate. Use it everywhere digests are computed internally, avoiding `digest::finish` completely, including transitive uses. This requires adding new non-panicking variants of several APIs. For now, make those variants non-public, until tests and documentation are updated. This is a bit too extreme because we know some of these cases will never fail as the input is known to be short. We will need to choose to either just accept this, or introduce another new (internal?) infallible API.
briansmith
force-pushed
the
b/panic-less-1
branch
from
d742e3a to
d434fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
digest::try_finishto the rest of the crate. Use it everywhere digests are computed internally, avoidingdigest::finishcompletely, including transitive uses. This requires adding new non-panicking variants of several APIs. For now, make those variants non-public, until tests and documentation are updated.This is a bit too extreme because we know some of these cases will never fail as the input is known to be short. We will need to choose to either just accept this, or introduce another new (internal?) infallible API.