CI: Address clippy lints and upgrade tools so CI succeeds #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2149 +/- ##
==========================================
- Coverage 97.12% 96.97% -0.16%
==========================================
Files 151 151
Lines 20101 19597 -504
Branches 447 468 +21
==========================================
- Hits 19524 19004 -520
- Misses 482 487 +5
- Partials 95 106 +11 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/clippy-1.81
branch
from
9a26aa3
to
79e0eac
Compare
Address new complaints from Clippy.
briansmith
force-pushed
the
b/clippy-1.81
branch
from
79e0eac
to
35e4624
Compare
Address a new complaint from the newest Clippy. Remove the relevant outdated/misleading advice in STYLE.md.
0.31.0 doesn't work any more. Also fix the cache key used in the job.
The older version we have been using is failing to build in CI.
The older version we have been using is failing to build in CI.
briansmith
force-pushed
the
b/clippy-1.81
branch
5 times, most recently
from
0bac8ee
to
0ff704d
Compare
The version of the Android NDK used in GitHub Actions, /usr/local/lib/android/sdk/ndk/27.1.12297006, doesn't support SDK version 19 (or 20) any more.
briansmith
force-pushed
the
b/clippy-1.81
branch
from
0ff704d
to
1973e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit message for details.