Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm: Switch from denylisting Apple targets to allowlisting Android/Linux. #2116

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

briansmith
Copy link
Owner

The allowlist approach is safer.

@briansmith briansmith self-assigned this Jun 21, 2024
@briansmith
Copy link
Owner Author

@eugenehp Thanks for your comment in the other PR about the target_vendor usage. It caused me to reconsider some of the use of it, and this PR removes those uses. PTAL.

I think the rest of the target_vendor = "apple" usage is benign if redundant. I guess if/when it causes trouble we can reconsider it.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.07%. Comparing base (9593d9b) to head (88a3445).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2116   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         144      144           
  Lines       20124    20124           
  Branches      456      456           
=======================================
+ Hits        19535    19536    +1     
  Misses        492      492           
+ Partials       97       96    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit 3e9e2eb into main Jun 22, 2024
158 checks passed
@briansmith briansmith deleted the b/target-vendor branch June 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant